Removed Obsolete SDK_INT Version Checks #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @RajaVamsi11 You have 4 pmd violations. probably for all 4 file changes. |
|
Yes, How do I know where they are going wrong? I tried gradlew build but it didn't help. |
|
Did u try checking this file? |
|
The reports folders is not creating when i run gradlew command
…On Sat, 14 Mar, 2020, 11:40 AM Chinmay Kulkarni, ***@***.***> wrote:
Did u try checking this file?
*android-client/mifosng-android/build/reports/pmd/pmd.html*
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1399 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJCQK7RTG4FDRI3EWHGRKTRHMNUFANCNFSM4LEFBDIA>
.
|
|
@RajaVamsi11 okay let me check. |
|
@RajaVamsi11 there are 4 unused imports that's why it is failing |
|
@Grandolf49 Thanks. I will remove them and push the PR again. |
3be6e54 to
8d5f725
Compare
|
@Grandolf49 It worked. |
|
Hello @RajaVamsi11, Can you please correct your commit message so that it can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1398
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.