-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #804 - Fixes Wrong Fragment selection #1230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@luckyman20 @moksh-mahajan Hi, It's been more than a day since I've pushed this PR please have a look !!! |
@OussEmaDevCode Sorry for the delay. |
@moksh-mahajan I hope I am not needed to intervene. |
mifosng-android/src/main/java/com/mifos/mifosxdroid/online/DashboardActivity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @OussEmaDevCode . The changes look fine. Just replace the code with switch case as @laxyapahuja suggested to make code a bit clean.
@moksh-mahajan @luckyman20 Hi, It's simply impossible to use switch statement with instanceof operator because the switch statement can only contain case statements which are compile time constants and which evaluate to an integer up to Java 6 and a string in Java 7. And Since I didn't want to deceive you I did this solution with involves the class names instead of the actual classes. Hope it's fine !!!! |
mifosng-android/src/main/java/com/mifos/mifosxdroid/online/DashboardActivity.java
Outdated
Show resolved
Hide resolved
@moksh-mahajan That will create a style error like this 'the line exceeds 100 characters' and the build will fail. |
@OussEmaDevCode I mean to say line no. 245 can be merged with line no. 244 |
@moksh-mahajan Done !!! |
mifosng-android/src/main/java/com/mifos/mifosxdroid/online/DashboardActivity.java
Outdated
Show resolved
Hide resolved
Fix fix fix fix fix
@moksh-mahajan Done !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @OussEmaDevCode
@moksh-mahajan is it going to be merged ? |
Fixes #804
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.