Added margin in Group details activity #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@santoshconflux @luckyman20 @jddeep @harshinde07 Please review and approve. Thanks. |
|
@PiyushSharma99 Attach screenshot too. |
|
@luckyman20 Added screenshot. Thanks! |
|
@luckyman20 Please review and approve. @jddeep Could you please approve my submission on the gci portal? |
|
Push the changes to Also, change your commit tile to |
|
@luckyman20 How can I change this now? I mean change the base branch where I want to push the changes. Do i open a new PR? |
|
@luckyman20 There is no development branch! |
|
@PiyushSharma99 Sorry, my bad. This project doesn't have that. Just fix up the commit title and you would be good to go. |
2e22d6d to
6be3d3a
Compare
|
Done 👍 @luckyman20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1192
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.