Feat: Added feature to add client image through camera or gallery while creating a client. #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarun0
requested changes
Jun 15, 2019
...roid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientFragment.java
Outdated
Show resolved
Hide resolved
...roid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientFragment.java
Outdated
Show resolved
Hide resolved
...roid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientFragment.java
Outdated
Show resolved
Hide resolved
...roid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientFragment.java
Outdated
Show resolved
Hide resolved
...oid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientPresenter.java
Outdated
Show resolved
Hide resolved
...oid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientPresenter.java
Outdated
Show resolved
Hide resolved
...oid/src/main/java/com/mifos/mifosxdroid/online/createnewclient/CreateNewClientPresenter.java
Outdated
Show resolved
Hide resolved
| @@ -106,7 +128,9 @@ | |||
| CreateNewClientPresenter createNewClientPresenter; | |||
|
|
|||
| View rootView; | |||
| private boolean createClientWithImage = false; | |||
There was a problem hiding this comment.
Provide some better name which clarifies its use. It seems like a flag to save the state. Alternatively, (though less preferred) add a comment here about the variable usage so that future developers may get idea about why it was used.
198e27d to
7849eee
Compare
|
@tarun0 I have made the requested changes. Please review. |
|
@moksh-mahajan Please resolve merge conflicts |
7849eee to
fa70982
Compare
|
@moksh-mahajan can you review this task |
|
@moksh-mahajan Please fix conflicts. |
…ating a client. The workflow is like this: After the creation of a new client, in the response clientId is provided, and this using this clientId a new http request is made to upload client picture either from camera or through gallery.
1e595d9 to
2f9557a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow is like this: After the creation of a new
client, in the response clientId is provided, and this using this clientId a new HTTP request is made to upload client picture either from
camera or through the gallery.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.