Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1128 UI improvement: white space above tool bar bug. #1151

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Fix issue #1128 UI improvement: white space above tool bar bug. #1151

merged 1 commit into from
Mar 19, 2020

Conversation

DylanRobson
Copy link

Changed fragment_client.xml and activity_dashboard.xml to set fitsSystemWindows="true".

(Tested in online and offline mode)...

  • Tested that there was no whitespace above tool bar when navigating: Centers -> Dashboard, and Groups-> Dashboard.
  • Tested that there was no whitespace above tool bar when navigating: Centers -> Clients, and Groups -> Clients.

Fixes #1128

Please Add Screenshots If there are any UI changes.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Changed fragment_client.xml and activity_dashboard.xml to set fitsSystemWindows="true".
Copy link
Collaborator

@moksh-mahajan moksh-mahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@therajanmaurya therajanmaurya merged commit 2bc6a9d into openMF:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI improvement: White space is created above the app bar.
5 participants