Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client name character limit #746

Closed
mmyint2 opened this issue Aug 8, 2017 · 7 comments
Closed

Client name character limit #746

mmyint2 opened this issue Aug 8, 2017 · 7 comments

Comments

@mmyint2
Copy link

mmyint2 commented Aug 8, 2017

The First Name and Last Name fields for client creation require a minimum of 4 characters. This is a problem as clients may have a first or last name that is only 3 characters or less.

@mayank-kgp
Copy link
Contributor

@droidchef As per comment of @mmyint2 we should allow the name which is less than 3 characters too. So I removed the length validation.

@therajanmaurya
Copy link
Member

therajanmaurya commented Aug 15, 2017 via email

@droidchef
Copy link
Member

Well atleast there should be 1 character, this is what I meant when I said don't remove the validation. Atleast tell the user the name cannot be empyu.

@mayank-kgp
Copy link
Contributor

@droidchef @therajanmaurya I think this line is taking care of the condition of having at least 1 character.

@mayank-kgp
Copy link
Contributor

@therajanmaurya How many characters should be there?

@therajanmaurya
Copy link
Member

Fix in #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants