-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client name character limit #746
Comments
These lines need a change |
@droidchef As per comment of @mmyint2 we should allow the name which is less than 3 characters too. So I removed the length validation. |
I agree with @droidchef <https://github.com/droidchef> first name less than
3 characters doesn't make sense and we should have validation. I checked
the backend code, they mentioned the upper limit but not lower limit.
I will check with @mmyint2 <https://github.com/mmyint2>.
https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java#L100
…On Tue, Aug 15, 2017 at 8:35 PM, MAYANK JINDAL ***@***.***> wrote:
@droidchef <https://github.com/droidchef> As per comment of @mmyint2
<https://github.com/mmyint2> we should allow the name which is less than
3 characters too. So I removed the length validation.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#746 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFdZQjZ5LMKYenMuYR3T5EuUavW1Kykoks5sYbOtgaJpZM4OwjV3>
.
--
*Thanks*
*Namaste*
Rajan Maurya
Contact Number : +91 9015090523
Github: https://github.com/therajanmaurya
College: Cluster Innovation Centre, University of Delhi
Student : B.Tech. (Information Technology & Mathematical Innovations)
|
Well atleast there should be 1 character, this is what I meant when I said don't remove the validation. Atleast tell the user the name cannot be empyu. |
@droidchef @therajanmaurya I think this line is taking care of the condition of having at least 1 character. |
@therajanmaurya How many characters should be there? |
Fix in #763 |
The First Name and Last Name fields for client creation require a minimum of 4 characters. This is a problem as clients may have a first or last name that is only 3 characters or less.
The text was updated successfully, but these errors were encountered: