null check

open4good · Nov 3, 2024 · c4ed946 · c4ed946
1 parent b50c717
commit c4ed946
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/commons/src/main/java/org/open4goods/commons/model/product/Product.java b/commons/src/main/java/org/open4goods/commons/model/product/Product.java
@@ -461,7 +461,7 @@ public String randomModel() {
 	 */
 	public String bestName() {
 		String ret;
-		if (null == brand() || null == model()) {
+		if (StringUtils.isEmpty(brand()) || StringUtils.isEmpty(model())) {
 			ret = shortestOfferName();
 		} else {
 			ret =  brandAndModel();