Bug fix

open4good · Oct 26, 2024 · 5451df9 · 5451df9
1 parent e7b9c40
commit 5451df9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 17 deletions.
diff --git a/commons/src/main/java/org/open4goods/commons/model/EcoScoreRanking.java b/commons/src/main/java/org/open4goods/commons/model/EcoScoreRanking.java
@@ -8,9 +8,9 @@ public class EcoScoreRanking {
 	// Number of items in ther vertical when the position was computed
 	private long globalCount;
 	// The best item id in the whole vertical
-	private long globalBest;
+	private Long globalBest;
 	// The better item id in the whole vertical (item just after)
-	private long globalBetter;
+	private Long globalBetter;
 
 
 
@@ -51,19 +51,6 @@ public void setSpecializedCount(long specializedCount) {
 		this.specializedCount = specializedCount;
 	}
 
-
-	public long getGlobalBest() {
-		return globalBest;
-	}
-	public void setGlobalBest(long globalBest) {
-		this.globalBest = globalBest;
-	}
-	public long getGlobalBetter() {
-		return globalBetter;
-	}
-	public void setGlobalBetter(long globalBetter) {
-		this.globalBetter = globalBetter;
-	}
 	public String getSpecializedBest() {
 		return specializedBest;
 	}
@@ -76,6 +63,18 @@ public String getSpecializedBetter() {
 	public void setSpecializedBetter(String specializedBetter) {
 		this.specializedBetter = specializedBetter;
 	}
+	public Long getGlobalBest() {
+		return globalBest;
+	}
+	public void setGlobalBest(Long globalBest) {
+		this.globalBest = globalBest;
+	}
+	public Long getGlobalBetter() {
+		return globalBetter;
+	}
+	public void setGlobalBetter(Long globalBetter) {
+		this.globalBetter = globalBetter;
+	}
 
 
 

diff --git a/ui/src/main/java/org/open4goods/ui/controllers/ui/ProductController.java b/ui/src/main/java/org/open4goods/ui/controllers/ui/ProductController.java
@@ -180,7 +180,7 @@ private ModelAndView buildProductView(Long id, String vertical, final HttpServle
 			Long globalBestId = data.getRanking().getGlobalBest();
 			Long globalBetter = data.getRanking().getGlobalBetter();
 
-			if (null != globalBestId) {
+			if (null != globalBestId && globalBestId.longValue() !=0) {
 				Product best = null;
 				try {
 					best = productRepository.getById(globalBestId);
@@ -191,7 +191,7 @@ private ModelAndView buildProductView(Long id, String vertical, final HttpServle
 				mv.addObject("best", best);
 			}
 
-			if (null != globalBetter) {
+			if (null != globalBetter && globalBetter.longValue() != 0) {
 				Product better = null;
 				try {
 					better = productRepository.getById(globalBetter);