Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce beta annotation and mark js grpc impl as beta #256

Merged
merged 3 commits into from
May 9, 2024

Conversation

andrewparmet
Copy link
Collaborator

No description provided.

@andrewparmet andrewparmet marked this pull request as ready for review May 9, 2024 04:12
@andrewparmet andrewparmet requested a review from ogolberg May 9, 2024 04:12

package protokt.v1

annotation class Beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment explaining what this annotation means

Copy link
Member

@ogolberg ogolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comment

@andrewparmet andrewparmet merged commit 0fb44da into main May 9, 2024
13 checks passed
@andrewparmet andrewparmet deleted the mark-js-grpc-impl-as-beta branch May 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants