Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes necessary to support protovalidate-java integration #211

Merged
merged 40 commits into from
Dec 27, 2023

Conversation

andrewparmet
Copy link
Collaborator

@andrewparmet andrewparmet commented Dec 26, 2023

  • Fix generation for map entries for maps of presence-tracked primitives in proto2, e.g. map<int32, int32>.
  • Fix generation for maps with reserved names (e.g. val)
  • Fix full type name generation for nested messages
  • Add KtProperty annotation so that you can get a property's field number reflectively

@andrewparmet andrewparmet merged commit a03694a into open-toast:main Dec 27, 2023
@andrewparmet andrewparmet deleted the more-descriptors branch December 27, 2023 16:27
ogolberg pushed a commit to ogolberg/protokt that referenced this pull request Jan 2, 2024
…st#211)

- Fix generation for map entries for maps of presence-tracked primitives in proto2, e.g. `map<int32, int32>`.
- Fix generation for maps with reserved names (e.g. `val`)
- Fix full type name generation for nested messages
- Add `KtProperty` annotation so that you can get a property's field number reflectively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants