Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement code generation using KotlinPoet #143

Merged
merged 76 commits into from
Oct 22, 2021
Merged

Reimplement code generation using KotlinPoet #143

merged 76 commits into from
Oct 22, 2021

Conversation

andrewparmet
Copy link
Collaborator

@andrewparmet andrewparmet commented Oct 21, 2021 •
edited
Loading

@andrewparmet
fixup broken test, common protos grpc
af9d62a
@andrewparmet
add protoc install step
1575b6d
@andrewparmet
try protoc again
215d900
@andrewparmet
try again
589bf53
@andrewparmet
add job dependency
b45cf74
@andrewparmet
install curl?
0f590be
@andrewparmet
alpine
c13a3c8
@andrewparmet
no sudo
f464d24
@andrewparmet
call protoc
fcdd01a
@andrewparmet
try finding protoc
2b11b21
@andrewparmet
try caching protoc
4a4f49c
@andrewparmet
install protoc as command
0e694de
@andrewparmet
give command a name
ac5639a
@andrewparmet
include buildSrc classes in codegen
664fa81
@andrewparmet
use sourceSets for common gradle code rather than copying class files…
edecb8f 
… around
@andrewparmet
clean up test
b51b711
@andrewparmet
remove extra line
3a1b449
@andrewparmet
begin kotlinpoet migration
2035a86
@andrewparmet
wip
2d0d303
@andrewparmet
map entry converted
a37d0ec
@andrewparmet
message constructor
694b309
@andrewparmet
serialize method
39973b7
@andrewparmet
serialize method
39cd413
@andrewparmet
messageSize
a690265
@andrewparmet
equals and hashCode
25f7bea
@andrewparmet
toString
bcc85f8
@andrewparmet
dsl copy
a915e40
@andrewparmet
dsl short of build method
ae9e5fa
@andrewparmet
implement build
bafef27
@andrewparmet
begin work on deserializer
8b09548
andrewparmet and others added 26 commits October 11, 2021 15:06
@andrewparmet
undo some changes
6a254d1
@andrewparmet
clean up enum generation
1685b5a
@andrewparmet
finish cleaning up enums
f01d6af
@andrewparmet
begin cleaning up map entry
d6b04ab
@andrewparmet
extract deserializer construction
e237a23
@pranjalvachaspati-toast
Remove dead code, start to add some ktdoc (#2)
36ca69e
@andrewparmet
lint
6186573
@andrewparmet
start using TypeName in properties
b6f6f35
@andrewparmet
clean up some deprecation handling and indentation
8a03480
@andrewparmet
clean up some message annotation logic
419f556
@andrewparmet
clean up interface implementation
cabd657
@andrewparmet
start passing enum type name around
f8774b6
@andrewparmet
file descriptor resolution resolves imports through kotlinpoet
12fe227
@andrewparmet
the absolute minimum to get latest kotlinpoet
d8a2658
@andrewparmet
1.5.21
d4fcbc5
@andrewparmet
use code block with named parameters
a8b955b
@andrewparmet
start using type names for all properties
eb9b619
@andrewparmet
remove all uses of typevariablename
3f8bc46
@andrewparmet
add failing tests that are now passing
702ddd2
@andrewparmet
Merge branch 'main' into kotlinpoet
d92e6d5
@pranjalvachaspati-toast
Remove importresolver package (#5)
f9afebb
@andrewparmet
Merge branch 'main' into kotlinpoet
dea9213
@andrewparmet
clean up a bit
703fde2
@andrewparmet
lint and some cleanup
bb5d784
@andrewparmet
remove more dead code
db2a4e4
@andrewparmet
remove most usages of enclosing messages
b1e1921
@andrewparmet andrewparmet merged commit fb79386 into open-toast:main Oct 22, 2021
@andrewparmet andrewparmet deleted the kotlinpoet branch October 22, 2021 14:33
andrewparmet added a commit to andrewparmet/protokt that referenced this pull request Oct 22, 2021
@andrewparmet @pranjalvachaspati-toast
Reimplement code generation using KotlinPoet (open-toast#143)
67db17d 
Co-authored-by: pranjalvachaspati-toast <pranjal.vachaspati@toasttab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogolberg ogolberg ogolberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@andrewparmet @ogolberg @pranjalvachaspati-toast