-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Define url.scheme
in terms of logical operation in HTTP server semconv
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
Define
BREAKING: Define Oct 10, 2023
url.scheme
in terms of logical operation in HTTP server semconvurl.scheme
in terms of logical operation in HTTP server semconv
trask
force-pushed
the
http-server-url-scheme
branch
from
October 10, 2023 20:32
3aa6920
to
adc490a
Compare
AlexanderWert
approved these changes
Oct 11, 2023
Oberon00
approved these changes
Oct 11, 2023
I think we should add a paragraph to the HTTP spec on how to reconstruct the URL (basically just the list you have added in the PR description), this would also be useful for instrumentation writers to clarify how to fill in the components. |
mateuszrzeszutek
approved these changes
Oct 11, 2023
jsuereth
approved these changes
Oct 11, 2023
arminru
approved these changes
Oct 11, 2023
lmolkova
reviewed
Oct 11, 2023
lmolkova
approved these changes
Oct 11, 2023
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/opentelemetry-specification#3442
Changes
Define
url.scheme
in terms of logical operation in HTTP server semconv.There are two reasons I think this is a good change.
Reason 1
I believe one of the motivations for these attributes on the server side is to reconstruct the original URL:
server.address
server.port
url.path
url.query
url.scheme
(e.g.
server.address
andserver.port
are captured from theHost
header)Reason 2
We should have a place to capture the scheme used by the immediate peer soon, under something like
tls.protocol.name
(#21).Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.