Skip to content

Commit

Permalink
Fix server.port requirement level
Browse files Browse the repository at this point in the history
  • Loading branch information
trask committed Oct 19, 2023
1 parent e0767b2 commit 7df62e7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ release.
([#410](https://github.com/open-telemetry/semantic-conventions/pull/410))
- BREAKING: Factor in `X-Forwarded-Host` / `Forwarded` when capturing `server.address` and `server.port`.
([#411](https://github.com/open-telemetry/semantic-conventions/pull/411))
- Fix `server.port` to be not required when `server.address` is not set.
([#429](https://github.com/open-telemetry/semantic-conventions/pull/429))

### Features

Expand Down
2 changes: 1 addition & 1 deletion docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ MUST NOT include the port identifier.
[X-Forwarded-Host](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host), or a similar header.
- Port identifier of the `Host` header

**[6]:** If not default (`80` for `http` scheme, `443` for `https`).
**[6]:** If `server.address` is set and the port is not default (`80` for `http` scheme, `443` for `https`).

**[7]:** When missing, the value is assumed to be `/`

Expand Down
2 changes: 1 addition & 1 deletion model/http-common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ groups:
[X-Forwarded-Host](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host), or a similar header.
- Port identifier of the `Host` header
requirement_level:
conditionally_required: If not default (`80` for `http` scheme, `443` for `https`).
conditionally_required: If `server.address` is set and the port is not default (`80` for `http` scheme, `443` for `https`).
- ref: url.scheme
requirement_level: required
examples: ["http", "https"]
Expand Down

0 comments on commit 7df62e7

Please sign in to comment.