Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Report an error when URLs are missing from an integrations registry entry #5107

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 26, 2024

  • Reformats shortcode to make it easier to read
  • Adds to checks for missing URLs, and reports an error (fails the build), when they are missing. (This should probably be a warning, but it matches the other checks that are done.

Note: I know that another partial does similar checks, but maybe not for Integration entries? Anyhow, these checks are now closer to their point of use.

/cc @svrnm

The generated site files are the same (other than the site-build timestamp).

$ (cd public && git diff)                                                                          
diff --git a/site/index.html b/site/index.html
index 4555d76f20..6ed7ea752e 100644
--- a/site/index.html
+++ b/site/index.html
@@ -226,7 +226,7 @@ Attribute Value Netlify built false Deploy context local ">
 <script>
 document.addEventListener("DOMContentLoaded", function() {
   var options = { hour: '2-digit', hour12: false, minute: '2-digit', timeZoneName: 'short' };
-  var buildDate = new Date("2024-08-26T18:49:33-04:00");
+  var buildDate = new Date("2024-08-26T19:26:49-04:00");
   document.getElementById("local-time").innerText = buildDate.toLocaleString(undefined, options);
 });
 </script>

@chalin chalin added the CI/infra CI & infrastructure label Aug 26, 2024
@chalin chalin requested a review from a team August 26, 2024 23:28
@chalin chalin force-pushed the chalin-report-registry-intgnt-entry-error-2024-08-26 branch 3 times, most recently from 41d81ea to 9418c7d Compare August 29, 2024 21:16
@chalin chalin force-pushed the chalin-report-registry-intgnt-entry-error-2024-08-26 branch from 9418c7d to 5ec3cd5 Compare August 30, 2024 11:15
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chalin chalin mentioned this pull request Sep 2, 2024
24 tasks
@svrnm svrnm added this pull request to the merge queue Sep 4, 2024
Merged via the queue into open-telemetry:main with commit 50d1031 Sep 4, 2024
17 checks passed
@chalin chalin deleted the chalin-report-registry-intgnt-entry-error-2024-08-26 branch September 4, 2024 22:08
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants