Fix complication bug in Go Resources page #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2024
theletterf
approved these changes
Feb 6, 2024
|
@open-telemetry/go-instrumentation-maintainers Please have a look — thanks! |
@open-telemetry/go-approvers 😉 |
dmathieu
approved these changes
Feb 6, 2024
cartermp
approved these changes
Feb 6, 2024
MrAlias
reviewed
Feb 6, 2024
| ) | ||
| if err != nil { | ||
| log.Println(err) // Log issues during resource creation. Note that resource.New still returns a resource. |
There was a problem hiding this comment.
I'm not sure this is guaranteed. We make this guarantee for two specific error types, but the user needs to check res is not nil before they can safely use it in all cases.
There was a problem hiding this comment.
I will make a followup PR once open-telemetry/opentelemetry-go#4887 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example of
resource.Newdoes not even compile.I updated the example to match open-telemetry/opentelemetry-go#4887