Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated trace timestamps #2313

Merged
merged 1 commit into from
Feb 9, 2023
Merged

updated trace timestamps #2313

merged 1 commit into from
Feb 9, 2023

Conversation

Neilblaze
Copy link
Contributor

@Neilblaze Neilblaze commented Feb 9, 2023 •
edited
Loading

Target :

Under Sample Trace in #tracing-in-opentelemetry timestamp of the second event is greater than the end_time of the span itself.

Hence, it has been updated!

fixes : #2287
cc : @svrnm @cartermp

@Neilblaze Neilblaze requested a review from a team February 9, 2023 15:07
cartermp
cartermp approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp cartermp merged commit 51a7157 into open-telemetry:main Feb 9, 2023
@Neilblaze Neilblaze deleted the fix-timestamp-repositioning branch February 9, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong timestamp for span event
2 participants
@Neilblaze @cartermp