-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo docs, temporarily via git submodule #2246
Add demo docs, temporarily via git submodule #2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
I like it as well! One suggestion: There's a lot of documents below the top level navigation, maybe there should be some folders? |
Yes, I can fix that in the demo repo (for the doc sections that already exist) once this lands. WDYT? |
@chalin I think we're comfortable calling the docs stable. @open-telemetry/demo-approvers feel free to chime in otherwise |
The only thing that doesn't look nice is the architecture page, where we are using Mermaid in GH, but in the docs we have just the text. |
9b8a8ab
to
70ff132
Compare
Thanks for the feedback @cartersocha and @julianocosta89.
@julianocosta89 - done, see https://deploy-preview-2246--opentelemetry.netlify.app/docs/demo/current_architecture/. Best viewed on a wide display. (I'll try to fix the layout in a followup PR.) With this change in, can someone from the demo team approve this PR? |
Thanks @reyang! I've updated the submodule to refer to the current HEAD. Note that "View page source" etc, won't work until I move the pages into this repo. (I could get them to work, but it isn't worth implementing it for this temporary situation.) Merging! |
WDYT @svrnm @cartermp @austinlparker @open-telemetry/demo-approvers ?
Preview: https://deploy-preview-2246--opentelemetry.netlify.app/docs/demo
p.s. I know that the scripts are misnamed, but I wanted to keep changes to a minimum in this PR.