Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog entry about Jaeger OTLP and deprecation #1892

Merged
merged 17 commits into from
Nov 3, 2022

Conversation

breedx-splk
Copy link
Contributor

@breedx-splk breedx-splk commented Oct 21, 2022

@breedx-splk breedx-splk requested review from a team October 21, 2022 18:31
@reese-lee
Copy link
Member

Not a blog approver, but I think it's very clear and well-organized! I always appreciate these aspects of any written communication.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just some small questions.

content/en/blog/2022/jaeger-native-otlp/index.md Outdated Show resolved Hide resolved
- Are you an OpenTelemetry user currently sending data to Jaeger?
- Are you using the Jaeger client exporters, or have you already made the switch
to OTLP?
- How painful will it be for you to migrate to native OTLP with Jaeger?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is worth putting in the blog post, but a fairly "obvious" action we should take is ensuring that every piece of docs that explains how to set up a jaeger exporter needs updating to show how to do it with OTLP. I would expect anyone's feedback to this question to be dependent on what the plan is for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agreed. I hope this isn't too much cart before the horse, and I would expect that we could update the docs during the deprecation phase.

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

content/en/blog/2022/jaeger-native-otlp/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/jaeger-native-otlp/index.md Outdated Show resolved Hide resolved
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm -- will this be cross-published onto the Jaeger blog?

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, thanks.

content/en/blog/2022/jaeger-native-otlp/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/jaeger-native-otlp/index.md Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor

@breedx-splk do you have permissions to cross-post to the jaeger blog as well?

breedx-splk and others added 2 commits October 31, 2022 08:50
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
breedx-splk and others added 3 commits October 31, 2022 08:57
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@breedx-splk
Copy link
Contributor Author

@breedx-splk do you have permissions to cross-post to the jaeger blog as well?
overall lgtm -- will this be cross-published onto the Jaeger blog?

@austinlparker @cartermp A really good idea. I've reached out to @yurishkuro on the spec issue to see if he can help with cross-posting.

@cartermp
Copy link
Contributor

@breedx-splk sounds good to me. I am happy to merge as-is for now. Just a question of timing.

@yurishkuro
Copy link
Member

I have a couple suggestions:

  • be explicit in the blog about which exporters are in scope, like Thrift over UDP, Thrift over HTTP, etc.
  • it may be worth a brief discussion on the implications of removing the exporters. Currently the blog sounds like it's nearly a complete no-op, just swap jaeger->otlp exporter, but that's not the case if people are running Jaeger agent.
  • could we add a poll to the PR asking people to vote for the preferred length of deprecation phase?

@breedx-splk
Copy link
Contributor Author

Ok, the survey is up and I've added links to it. I've also taken @yurishkuro's advice and spelled out exactly which exporters are to be deprecated and some high level descriptions of the user impact for each.
Thanks for helping out with this y'all.

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@govindrai
Copy link

govindrai commented Nov 2, 2022

Now that Jaeger supports OTLP, this feels like a step backwards: It results in
an increased maintenance burden with very little benefit.

this text occurs is in the readme twice.

@breedx-splk
Copy link
Contributor Author

Now that Jaeger supports OTLP, this feels like a step backwards: It results in
an increased maintenance burden with very little benefit.

this text occurs is in the readme twice.

Oof, thanks, I think that was a merge/rebase fail. Fixing that up now.

@cartermp cartermp merged commit 7148ac6 into open-telemetry:main Nov 3, 2022
@yurishkuro
Copy link
Member

@breedx-splk if you want to repost this to Jaeger blog, we have two options:

  • I can do it as a copy & paste with a back link, or
  • You can author the post on Medium and add it to the Jaeger publication. I will need to know your medium username to be able to add you as a writer.

@breedx-splk
Copy link
Contributor Author

@breedx-splk if you want to repost this to Jaeger blog, we have two options:

  • I can do it as a copy & paste with a back link, or
  • You can author the post on Medium and add it to the Jaeger publication. I will need to know your medium username to be able to add you as a writer.

Thanks @yurishkuro. I'm flexible -- but I don't currently have a Medium account, so if you're willing to do a copy/paste that would be awesome! ❤️


We intend to **deprecate Jaeger exporters from OpenTelemetry** in the near
future, and are looking for your feedback to determine the length of the
depreation phase. The best way to provide feedback is by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: depreation -> deprecation

@breedx-splk
Copy link
Contributor Author

https://medium.com/@YuriShkuro/better-alignment-with-opentelemetry-by-focusing-on-otlp-f3688939073f

Thanks again for your help and support! 🤜🏻 🤛🏻

@yurishkuro
Copy link
Member

Looking forward to the survey results. Please post them in the PR. Do you have something in mind for how long you want to keep the survey open? 1-2w?

@breedx-splk
Copy link
Contributor Author

@yurishkuro 2w seems good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants