Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by automated URLSessionInstrumentation when used in combination with GoogleMaps SDK #523

Conversation

batuhansk
Copy link
Contributor

Fixes #522

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.34%. Comparing base (2796cc0) to head (469b26b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files         336      336           
  Lines       14466    14467    +1     
=======================================
+ Hits         9597     9598    +1     
  Misses       4869     4869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the defensive check to prevent crash looks good to me.

Copy link
Member

@nachoBonafonte nachoBonafonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nachoBonafonte nachoBonafonte merged commit 812e3fc into open-telemetry:main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash caused by automated URLSessionInstrumentation when used in combination with GoogleMaps SDK
3 participants