Remove duplicate appending of log records #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nachoBonafonte
approved these changes
Jan 18, 2024
bryce-b
approved these changes
Jan 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 66.42% 66.46% +0.03%
==========================================
Files 336 336
Lines 14446 14444 -2
==========================================
+ Hits 9596 9600 +4
+ Misses 4850 4844 -6 ☔ View full report in Codecov by Sentry. |
320d779 to
304dd19
Compare
nachoBonafonte
added a commit
to nachoBonafonte/opentelemetry-swift
that referenced
this pull request
Feb 1, 2024
* main: Revert automatic version number (open-telemetry#511) Removed duplicate appending of log records (open-telemetry#504) # Conflicts: # Sources/Exporters/OpenTelemetryProtocolHttp/logs/OtlpHttpLogExporter.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #497 that causes all log records to be duplicated.