Fix build warnings in our code (left some test warnings that are real) (

#620)

Co-authored-by: Bryce Buchanan <75274611+bryce-b@users.noreply.github.com>

Examples/ConcurrencyContext/main.swift

@@ -14,7 +14,7 @@ let sampleValue = "sampleValue"
 // On Apple platforms, the default is the activity based context manager. We want to opt-in to the structured concurrency based context manager instead.
 OpenTelemetry.registerDefaultConcurrencyContextManager()
 
-let stdout = StdoutExporter()
+let stdout = StdoutSpanExporter()
 OpenTelemetry.registerTracerProvider(
     tracerProvider: TracerProviderBuilder().add(
         spanProcessor: SimpleSpanProcessor(spanExporter: stdout)
@@ -30,7 +30,7 @@ extension Task where Failure == Never, Success == Never {
 }
 
 func simpleSpan() async throws {
-    let span = tracer.spanBuilder(spanName: "SimpleSpan").setSpanKind(spanKind: .client).startSpan()
+    let span = await tracer.spanBuilder(spanName: "SimpleSpan").setSpanKind(spanKind: .client).startSpan()
     span.setAttribute(key: sampleKey, value: sampleValue)
     try await Task.sleep(seconds: 0.5)
     span.end()
@@ -42,15 +42,15 @@ func childSpan() async throws {
         span.setAttribute(key: sampleKey, value: sampleValue)
         await Task.detached {
             // A detached task doesn't inherit the task local context, so this span won't have a parent.
-            let notAChildSpan = tracer.spanBuilder(spanName: "notAChild").setSpanKind(spanKind: .client).startSpan()
+            let notAChildSpan = await tracer.spanBuilder(spanName: "notAChild").setSpanKind(spanKind: .client).startSpan()
             notAChildSpan.setAttribute(key: sampleKey, value: sampleValue)
             notAChildSpan.end()
         }.value
 
         try await Task {
             // Normal tasks should still inherit the context.
             try await Task.sleep(seconds: 0.2)
-            let childSpan = tracer.spanBuilder(spanName: "childSpan").setSpanKind(spanKind: .client).startSpan()
+            let childSpan = await tracer.spanBuilder(spanName: "childSpan").setSpanKind(spanKind: .client).startSpan()
             childSpan.setAttribute(key: sampleKey, value: sampleValue)
             try await Task.sleep(seconds: 0.5)
             childSpan.end()

Examples/Logs Sample/main.swift

@@ -17,9 +17,6 @@ func configure() {
       target: .hostAndPort("localhost", 4317),
       eventLoopGroup: MultiThreadedEventLoopGroup(numberOfThreads: 1))
 
-
-  OtlpLogExporter(channel: ClientConnection(configuration: configuration))
-
       OpenTelemetry.registerLoggerProvider(loggerProvider: LoggerProviderBuilder().with(processors: [
         BatchLogRecordProcessor(logRecordExporter:OtlpLogExporter(channel: ClientConnection(configuration: configuration)))]).build())
 

Examples/OTLP Exporter/main.swift

@@ -32,7 +32,7 @@ let configuration = ClientConnection.Configuration.default(
 let client = ClientConnection(configuration: configuration)
 
 let otlpTraceExporter = OtlpTraceExporter(channel: client)
-let stdoutExporter = StdoutExporter()
+let stdoutExporter = StdoutSpanExporter()
 let spanExporter = MultiSpanExporter(spanExporters: [otlpTraceExporter, stdoutExporter])
 
 let spanProcessor = SimpleSpanProcessor(spanExporter: spanExporter)

Examples/OTLP HTTP Exporter/main.swift

@@ -23,7 +23,7 @@ let instrumentationScopeName = "OTLPHTTPExporter"
 let instrumentationScopeVersion = "semver:0.1.0"
 
 let otlpHttpTraceExporter = OtlpHttpTraceExporter()
-let stdoutExporter = StdoutExporter()
+let stdoutExporter = StdoutSpanExporter()
 let spanExporter = MultiSpanExporter(spanExporters: [otlpHttpTraceExporter, stdoutExporter])
 
 let spanProcessor = SimpleSpanProcessor(spanExporter: spanExporter)

Examples/Simple Exporter/main.swift

@@ -23,7 +23,7 @@ let instrumentationScopeVersion = "semver:0.1.0"
 var tracer: TracerSdk
 let jaegerCollectorAddress = "localhost"
 let jaegerExporter = JaegerSpanExporter(serviceName: "SimpleExporter", collectorAddress: jaegerCollectorAddress)
-let stdoutExporter = StdoutExporter()
+let stdoutExporter = StdoutSpanExporter()
 
 // let zipkinExporterOptions = ZipkinTraceExporterOptions()
 // let zipkinExporter = ZipkinTraceExporter(options: zipkinExporterOptions)

Sources/Instrumentation/URLSession/URLSessionLogger.swift

@@ -158,7 +158,7 @@ class URLSessionLogger {
         }
         instrumentation.configuration.injectCustomHeaders?(&request, span)
         var instrumentedRequest = request
-        objc_setAssociatedObject(instrumentedRequest, &URLSessionInstrumentation.instrumentedKey, true, .OBJC_ASSOCIATION_COPY_NONATOMIC)
+        objc_setAssociatedObject(instrumentedRequest, URLSessionInstrumentation.instrumentedKey, true, .OBJC_ASSOCIATION_COPY_NONATOMIC)
         let propagators = OpenTelemetry.instance.propagators
         var traceHeaders = tracePropagationHTTPHeaders(span: span, textMapPropagator: propagators.textMapPropagator, textMapBaggagePropagator: propagators.textMapBaggagePropagator)
         if let originalHeaders = request.allHTTPHeaderFields {

Sources/OpenTelemetrySdk/Metrics/Stable/CallbackRegistration.swift

@@ -27,11 +27,11 @@ public class CallbackRegistration {
         if !hasStorages {
             return
         }
-        for var measurement in observableMeasurements {
+        for measurement in observableMeasurements {
             measurement.setActiveReader(reader: reader, startEpochNanos: startEpochNanos, epochNanos: epochNanos)
         }
         callback()
-        for var measurement in observableMeasurements {
+        for measurement in observableMeasurements {
             measurement.clearActiveReader()
         }
     }

Sources/OpenTelemetrySdk/Metrics/Stable/State/AsynchronousMetricStorage.swift

@@ -42,7 +42,7 @@ public class AsynchronousMetricStorage: MetricStorage {
         let newMeasurement = measurement.hasDoubleValue ? Measurement.doubleMeasurement(startEpochNano: start, endEpochNano: measurement.epochNano, value: measurement.doubleValue, attributes: processedAttributes) : Measurement.longMeasurement(startEpochNano: start, endEpochNano: measurement.epochNano, value: measurement.longValue, attributes: processedAttributes)
         do {
             try recordPoint(point: aggregator.toPoint(measurement: newMeasurement))
-        } catch let HistogramAggregatorError.unsupportedOperation(error) {
+        } catch HistogramAggregatorError.unsupportedOperation(_) {
             // TODO: log error
         } catch {
             // TODO: log default error
@@ -65,7 +65,7 @@ public class AsynchronousMetricStorage: MetricStorage {
     public func collect(resource: Resource, scope: InstrumentationScopeInfo, startEpochNanos: UInt64, epochNanos: UInt64) -> StableMetricData {
         var result: [[String: AttributeValue]: PointData]
         if aggregationTemporality == .delta {
-            var points = self.points
+            let points = self.points
             var lastPoints = self.lastPoints
             lastPoints = lastPoints.filter { element in
                 points[element.key] == nil // remove if points does not contain key

Tests/ExportersTests/DatadogExporter/Spans/SpansExporterTests.swift

@@ -18,9 +18,6 @@ class SpansExporterTests: XCTestCase {
     }
 
     func testWhenExportSpanIsCalled_thenTraceIsUploaded() throws {
-#if os(watchOS)
-        throw XCTSkip("Test is flaky on watchOS")
-#endif
        throw XCTSkip("Skipped flaky test.")
         var tracesSent = false
         let expec = expectation(description: "traces received")

Tests/ExportersTests/OpenTelemetryProtocol/OtlpTraceExporterTests.swift

@@ -13,7 +13,7 @@ import OpenTelemetryProtocolExporterCommon
 @testable import OpenTelemetrySdk
 import XCTest
 
-extension String: LocalizedError {
+extension Swift.String: LocalizedError {
     public var errorDescription: String? { return self }
 }
 

Tests/OpenTelemetrySdkTests/Logs/BatchLogRecordProcessorTests.swift

@@ -56,7 +56,7 @@ class BatchLogRecordProcessorTests : XCTestCase {
         for _ in 0 ..< 100 {
             logger.logRecordBuilder().emit()
         }
-        _ = processor.forceFlush()
+        processor.forceFlush()
         let exported = waitingExporter.waitForExport()
         XCTAssertEqual(exported?.count, 100)
         XCTAssertEqual(waitingExporter.exporter.exportCalledTimes, 1)