Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown-link-check and dead links #555

Merged
merged 7 commits into from
Apr 9, 2020
Merged

Fix markdown-link-check and dead links #555

merged 7 commits into from
Apr 9, 2020

Conversation

arminru
Copy link
Member

@arminru arminru commented Apr 8, 2020

Fixes #554

@bogdandrutu
Copy link
Member

Can you fix the link as well?

@arminru
Copy link
Member Author

arminru commented Apr 8, 2020

now it works 🙂

https://circleci.com/gh/open-telemetry/opentelemetry-specification/1892

image

@arminru
Copy link
Member Author

arminru commented Apr 8, 2020

specification/trace/sdk_exporters/zipkin.md linked to this paragraph:
https://github.com/open-telemetry/opentelemetry-specification/blob/0ea77a90e68f58f283cb95360ba7bd4d95d5ad8f/specification/data-semantic-conventions.md#semantic-conventions

The type of the attribute SHOULD be specified in the semantic convention for that attribute. Array values are allowed for attributes. For protocols that do not natively support array values such values MUST be represented as JSON strings.

Looks like it was accidentally removed in #546, I brought it back to where it was before.

@arminru arminru mentioned this pull request Apr 8, 2020
Closed
bogdandrutu
bogdandrutu approved these changes Apr 8, 2020
View reviewed changes
specification/trace/sdk_exporters/zipkin.md
@@ -73,7 +73,7 @@ attribute named `error`. In case if value of the attribute is `false`, Zipkin
tag needs to be omitted.

Array values MUST be serialized to string like a JSON list as mentioned in
[semantic conventions document](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/data-semantic-conventions.md#semantic-conventions).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, this passed because the file was available on the master branch when tested. So PR check would not catch this.

andrewhsu
andrewhsu approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I double-checked the links from latest git commit b1d3ca5 of this PR

@carlosalberto carlosalberto merged commit c04041e into open-telemetry:master Apr 9, 2020
@arminru arminru deleted the fix-markdownlinkcheck branch April 9, 2020 14:42
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@arminru
Fix markdown-link-check and dead links (open-telemetry#555)
0a61dc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@c24t c24t Awaiting requested review from c24t

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@jmacd jmacd Awaiting requested review from jmacd

@reyang reyang Awaiting requested review from reyang

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tedsuo tedsuo Awaiting requested review from tedsuo

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing markdown-link-check does not break build
4 participants
@arminru @bogdandrutu @andrewhsu @carlosalberto