Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: add attribute_group type to log.record #3374

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Editorial: add attribute_group type to log.record #3374

merged 5 commits into from
Apr 12, 2023

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Apr 7, 2023

Fixes warning when generating markdown

$ docker run -v /mnt/c/repo/opentelemetry-specification/semantic_conventions:/source -v /mnt/c/repo/opentelemetry-specification/specification:/dst otel/semconvgen:latest -f /source markdown -md /dst

Please set the type for group 'log.record' on line 2 - defaulting to type 'span'. See https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/syntax.md#groups

@lmolkova lmolkova requested review from a team April 7, 2023 16:33
@lmolkova lmolkova added area:semantic-conventions Related to semantic conventions spec:logs Related to the specification/logs directory labels Apr 7, 2023
@lmolkova
Copy link
Contributor Author

@open-telemetry/specs-approvers can someone please take a look at this nit ?

@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Apr 12, 2023
@reyang reyang merged commit b1207ff into open-telemetry:main Apr 12, 2023
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@lmolkova
Editorial: add attribute_group type to log.record (open-telemetry#3374)
056ddf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@Oberon00 Oberon00 Oberon00 approved these changes

@trask trask trask approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
area:semantic-conventions Related to semantic conventions editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:logs Related to the specification/logs directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lmolkova @trask @Oberon00 @reyang @bogdandrutu