-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic conventions for redis receiver #2145
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6ce30e6
Add semantic conventions for redis receiver
manang-splunk db31915
update CHANGELOG.md and README.md for redis resource semantic convention
manang-splunk f920bb8
added db.redis.instance semantic convention
manang-splunk e5f6243
added db.redis.instance attribute
manang-splunk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
groups: | ||
- id: redis | ||
prefix: db.redis | ||
brief: > | ||
A redis instance | ||
attributes: | ||
- id: instance | ||
type: string | ||
brief: > | ||
The reported name of the Redis instance. This can be in the form of | ||
`{host}:{port}` or any other name provided manually while configuring | ||
the instrumentation. If not provided, the default value is the `endpoint` | ||
value provided in the configuration. | ||
examples: ['localhost:6379', 'product_info_redis'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Redis | ||
|
||
**Status**: [Experimental](../../../document-status.md) | ||
|
||
**type:** `db.redis` | ||
|
||
**Description:** A redis instance | ||
|
||
<!-- semconv redis --> | ||
| Attribute | Type | Description | Examples | Required | | ||
|---|---|---|---|---| | ||
| `db.redis.instance` | string | The reported name of the Redis instance. This can be in the form of `{host}:{port}` or any other name provided manually while configuring the instrumentation. If not provided, the default value is the `endpoint` value provided in the configuration. | `localhost:6379`; `product_info_redis` | No | | ||
<!-- endsemconv --> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly searched and I didn't find another convention where the
id
is at a "different level" than theprefix
. I'm not sure if this is a problem though, just something that stand up for me.I guess you will also get a conflict if you have a structure like this:
id: db > id: db.redis > attributes > id: instance
? Similar to thisopentelemetry-specification/semantic_conventions/trace/database.yaml
Line 237 in d7a6b9f
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was getting conflicts while using id as
db
anddb.redis
.As we already have
db
anddb.redis
as id value in database attributes, we cannot use the same here. Therefore we have kept id asredis
.