Add Makefile and Travis CI build #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9df3fde to
7a9f573
Compare
c24t
approved these changes
Aug 2, 2019
carlosalberto
approved these changes
Aug 6, 2019
bogdandrutu
approved these changes
Aug 6, 2019
.gitignore
Outdated
| @@ -8,6 +8,10 @@ | |||
| .settings | |||
| bin | |||
|
|
|||
| # Go module | |||
| go.mod | |||
There was a problem hiding this comment.
for my curiosity, why this? We may need to update this.
There was a problem hiding this comment.
On a second thought I agree it's better to have the modules. Also added a tools.go to follow the best practice on having a consistent version on tools in 7b79cea.
bogdandrutu
approved these changes
Aug 6, 2019
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Add Makefile and Travis CI build * Simplify the script * Add to contributing guideline * Include Go modules and tools.go * Remove new line at eof
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add Makefile and Travis CI build * Simplify the script * Add to contributing guideline * Include Go modules and tools.go * Remove new line at eof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #199 (comment).
Need repo admins to set up Travis after this commit.