Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all typos #199

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix all typos #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/api-tracing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ record already completed span - [`SpanData`](#spandata) API HAVE TO be used.
## Status

`Status` interface represents the status of a finished `Span`. It's composed of
a canonical code in conjuction with an optional descriptive message.
a canonical code in conjunction with an optional descriptive message.

### StatusCanonicalCode

Expand Down
2 changes: 1 addition & 1 deletion specification/sdk-exporter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Shuts down the exporter. Called when SDK is shut down. This is an opportunity fo

## Further Language Specialization

Based on the generic interface definition layed out above library authors must define the exact interface for the particular language.
Based on the generic interface definition laid out above library authors must define the exact interface for the particular language.

Authors are encouraged to use efficient data structures on the interface boundary that are well suited for fast serialization to wire formats by protocol exporters and minimize the pressure on memory managers. The latter typically requires understanding of how to optimize the rapidly-generated, short-lived telemetry data structures to make life easier for the memory manager of the specific language. General recommendation is to minimize the number of allocations and use allocation arenas where possible, thus avoiding explosion of allocation/deallocation/collection operations in the presence of high rate of telemetry data generation.

Expand Down
4 changes: 2 additions & 2 deletions work_in_progress/specification/resource/Resource.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ an agent attaches further labels about the underlying VM, the cluster, or geo-lo

### From environment variables
Population of resource information from environment variables MUST be provided by the
core library. It provides the user with an ubiquitious way to manually provide information
core library. It provides the user with an ubiquitous way to manually provide information
that may not be detectable automatically through available integration libraries.

Two environment variables are used:
* `OC_RESOURCE_TYPE`: defines the resource type. Leading and trailing whitespaces are trimmed.
* `OC_RESOURCE_LABELS`: defines resource labels as a comma-seperated list of key/value pairs
* `OC_RESOURCE_LABELS`: defines resource labels as a comma-separated list of key/value pairs
(`[ <key>="value" [ ,<key>="<value>" ... ] ]`). `"` characters in values MUST be escaped with `\`.

For example:
Expand Down