Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec-compliance-matrix RecordException for Go #1576

Closed
wants to merge 1 commit into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 23, 2021

See #764 for more detail.

Resolves open-telemetry/opentelemetry-go#1595

@MrAlias MrAlias requested review from a team March 23, 2021 23:28
@tigrannajaryan
Copy link
Member

Was there a decision made that Go won't have RecordException? Reading #764 I cannot see a resolution.

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 24, 2021

@tigrannajaryan it is still an active discussion in open-telemetry/opentelemetry-go#1491. We would like to provide idiomatic handling of errors and panics but it is still unclear how this will map to exceptions. We plan to update this if things change.

@tigrannajaryan
Copy link
Member

@tigrannajaryan it is still an active discussion in open-telemetry/opentelemetry-go#1491. We would like to provide idiomatic handling of errors and panics but it is still unclear how this will map to exceptions. We plan to update this if things change.

@MrAlias Should we wait for the outcome of that discussion before marking this N/A in case it turns out not to be N/A? Or do you already know that it is definitely going to be a different approach for Go, so this line item is N/A no matter what is eventually decided?

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 25, 2021

@MrAlias Should we wait for the outcome of that discussion before marking this N/A in case it turns out not to be N/A? Or do you already know that it is definitely going to be a different approach for Go, so this line item is N/A no matter what is eventually decided?

Sure, sounds good 👍

@MrAlias MrAlias closed this Mar 25, 2021
@MrAlias MrAlias deleted the scm-go-exceptions branch March 25, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec Conformance Review: Traces/Span exceptions
4 participants