Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cloud.infrastructure_service attribute to resource spec #1112

Merged
merged 15 commits into from
Jan 7, 2021
Merged
Prev Previous commit
Next Next commit
updated table again
  • Loading branch information
William Armiros committed Oct 20, 2020
commit d26ecf090ff270054416a655781fb46e6221b851
2 changes: 1 addition & 1 deletion semantic_conventions/resource/cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ groups:
note: >
In AWS, this is called availability-zone.
examples: ['us-central1-a']
- id: infrastructure.service
- id: infrastructure_service
Copy link
Member

@Oberon00 Oberon00 Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if "infrastructure" is the best word here. For example, AWS (Lambda, ...) is not only IaaS, there is more than just the infrastructure provided. Although of course the infrastructure is also provided. So I guess infrastructure_service is fine, but maybe compute_service would be better. cloud.hosting_service or cloud.hosting_product may also make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree compute_service is good too - I'd just rather not change the key for a marginal naming improvement since it's already been included in recent releases of the collector contrib (e.g. here). But of course it's still in beta so if you feel strongly I'm happy to make the change :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. However, given that "infrastructure" could be interpreted in a broader sense, it should be fine, and the enumeration of well-known values will also make it clearer.

type:
allow_custom_values: true
members:
Expand Down
4 changes: 2 additions & 2 deletions specification/resource/semantic_conventions/cloud.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
| `cloud.account.id` | string | The cloud account ID used to identify different entities. | `opentelemetry` | No |
| `cloud.region` | string | A specific geographical location where different entities can run. | `us-central1` | No |
| `cloud.zone` | string | Zones are a sub set of the region connected through low-latency links. [1] | `us-central1-a` | No |
| `cloud.infrastructure.service` | string | The cloud infrastructure resource in use. | `EC2`<br>`VM`<br>`ComputeEngine` | No |
| `cloud.infrastructure_service` | string | The cloud infrastructure resource in use. | `EC2`<br>`VM`<br>`ComputeEngine` | No |

**[1]:** In AWS, this is called availability-zone.

Expand All @@ -23,7 +23,7 @@
| `azure` | Microsoft Azure |
| `gcp` | Google Cloud Platform |

`cloud.infrastructure.service` MUST be one of the following or, if none of the listed values apply, a custom value:
`cloud.infrastructure_service` MUST be one of the following or, if none of the listed values apply, a custom value:

| Value | Description |
|---|---|
Expand Down