-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cloud.infrastructure_service attribute to resource spec #1112
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f241fe7
added cloud.infrastructure.service attribute
491054c
Update specification/resource/semantic_conventions/cloud.md
willarmiros 845dfd4
updated table
d26ecf0
updated table again
f4a1b6f
Merge branch 'master' into infra-service
willarmiros 328d5df
addressed comments
8e97404
Merge branch 'master' into infra-service
willarmiros ccee0c5
changelog and comments
47a9c84
Update CHANGELOG.md
willarmiros 6df9b41
Update semantic_conventions/resource/cloud.yaml
willarmiros a9a1113
lowercased infra service values
66d4bbd
Merge branch 'master' into infra-service
willarmiros 9b58292
Merge branch 'master' into infra-service
willarmiros 4be0877
Merge branch 'master' into infra-service
willarmiros fea3418
Merge branch 'master' into infra-service
arminru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
updated table again
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if "infrastructure" is the best word here. For example, AWS (Lambda, ...) is not only IaaS, there is more than just the infrastructure provided. Although of course the infrastructure is also provided. So I guess infrastructure_service is fine, but maybe
compute_service
would be better.cloud.hosting_service
orcloud.hosting_product
may also make sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
compute_service
is good too - I'd just rather not change the key for a marginal naming improvement since it's already been included in recent releases of the collector contrib (e.g. here). But of course it's still in beta so if you feel strongly I'm happy to make the change :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. However, given that "infrastructure" could be interpreted in a broader sense, it should be fine, and the enumeration of well-known values will also make it clearer.