Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataPoint Flags are not mentioned in the Metrics Data Model #4053

Closed
mx-psi opened this issue May 17, 2024 · 4 comments · Fixed by #4135
Closed

DataPoint Flags are not mentioned in the Metrics Data Model #4053

mx-psi opened this issue May 17, 2024 · 4 comments · Fixed by #4135
Assignees
@pyohannes
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor

Comments

@mx-psi
Copy link
Member

mx-psi commented May 17, 2024

What are you trying to achieve?

I am working with the staleness marker added in open-telemetry/opentelemetry-proto/pull/316. It seems to be available on the proto, but not the data model.

What did you expect to see?

The staleness marker or datapoint flags more generally mentioned in the data model.

Additional context.

I guess what confuses me here is what the relationship between the proto and the data model is. Is the proto meant to be a superset of the data model? How should I interpret the semantics of fields present on the proto but not on the data model?
@mx-psi mx-psi added the spec:metrics Related to the specification/metrics directory label May 17, 2024
@arminru arminru added the area:data-model For issues related to data model label May 21, 2024
@dyladan
Copy link
Member

dyladan commented May 21, 2024

In the GC triage session we thought this was an interesting question that warranted TC attention:

I guess what confuses me here is what the relationship between the proto and the data model is.

@dyladan dyladan added triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted triage:deciding:tc-inbox Needs attention from the TC in order to move forward labels May 21, 2024
@tigrannajaryan tigrannajaryan added triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details and removed triage:deciding:tc-inbox Needs attention from the TC in order to move forward labels May 22, 2024
@jmacd
Copy link
Contributor

jmacd commented May 22, 2024

@pyohannes @zeitlinger As both of you have approached this topic from the perspective of how to report timeseries deletion, I'd like to involve you in thinking about how to update the data model to define how the flags fit the model.

@pyohannes pyohannes mentioned this issue Jul 9, 2024
Merged
5 tasks
@trask trask added triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor and removed triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted labels Jul 16, 2024
@trask trask assigned pyohannes and unassigned jmacd Jul 16, 2024
@trask trask moved this to Spec - In Progress in 🔭 Main Backlog Jul 16, 2024
@pyohannes
Copy link
Contributor

@mx-psi Can you please have a look at #4135, it should solve this issue.

@mx-psi
Copy link
Member Author

mx-psi commented Jul 18, 2024

Thanks for the ping, I had missed it, looks good to me!

carlosalberto pushed a commit that referenced this issue Aug 8, 2024
@pyohannes
Add data point flags to the metric data model (#4135)
f426c11 
Fixes #4053

## Changes

This PR extends the metric data model with data point flags, which were
added to the protocol in
open-telemetry/opentelemetry-proto#316.
@mx-psi mx-psi mentioned this issue Aug 20, 2024
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@pyohannes
Add data point flags to the metric data model (open-telemetry#4135)
0824fbf 
Fixes open-telemetry#4053

## Changes

This PR extends the metric data model with data point flags, which were
added to the protocol in
open-telemetry/opentelemetry-proto#316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyohannes pyohannes

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
Projects
🔭 Main Backlog
Status: Spec - Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add data point flags to the metric data model pyohannes/opentelemetry-specification
7 participants
@trask @dyladan @jmacd @tigrannajaryan @mx-psi @arminru @pyohannes