Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-plugin] Include trace ID in response headers for incoming requests #206

Closed
OlivierAlbertini opened this issue Aug 7, 2019 · 3 comments
Labels
spec:context Related to the specification/context directory
Milestone

Comments

@OlivierAlbertini
Copy link
Member

Hello

I would like to add the trace id in the response headers for incoming requests.
We would like to move the discussion in this repo (ref: open-telemetry/opentelemetry-js#166).

Is your feature request related to a problem? Please describe.

  • Having trace id in headers can help to debug slow requests we see in
    the browser by looking up the trace ID found in response headers.
  • It can help the propagation

Describe the solution you'd like

  • Inject trace id in the response header and only for incoming requests.
  • Make this feature optional and disabled by default

Thanks. Let me know if I can help.

@mtwo
Copy link
Member

mtwo commented Aug 7, 2019

FYI @bogdandrutu @AloisReitbauer @discostu105 @SergeyKanzhelev @iredelmeier

We've discussed this before at meetings of the W3C TraceContext group (which is mostly composed of OpenTelemetry contributors) and I think that it's a good idea, though we need to think through the implementation. Returning a trace context header in responses benefits the following scenarios:

  • It enables a basic case of delegated sampling, where the outermost layer of an application (typically a load balancer) can defer sampling decisions to the layer beneath it while still generating spans
  • This can assist with debugging across organizational / trust boundaries, where the caller of an API can record the trace ID returned to them by the API provider

I believe that there are a few unresolved conversations around whether TraceState should be returned as well.

@iredelmeier iredelmeier added the spec:context Related to the specification/context directory label Aug 13, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the Future milestone Sep 27, 2019
@SergeyKanzhelev
Copy link
Member

I triaged this as "future for now", meaning likely not in 1.0. Please reply back if this needs to be addressed earlier

@jmacd
Copy link
Contributor

jmacd commented Dec 4, 2019

The W3C committee is moving forward with a proposal, see w3c/trace-context#365
Closing for now.

@jmacd jmacd closed this as completed Dec 4, 2019
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:context Related to the specification/context directory
Projects
None yet
Development

No branches or pull requests

5 participants