Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of collector http client with pure hyper #853

Conversation

tomkarw
Copy link
Contributor

@tomkarw tomkarw commented Jul 26, 2022

Closes #843.

@tomkarw tomkarw requested a review from a team July 26, 2022 21:15
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@tomkarw tomkarw force-pushed the tomkarw/feat-implementation-of-collector-http-client-with-pure-hyper branch 2 times, most recently from d525f7e to d69f496 Compare July 28, 2022 21:32
@TommyCpp TommyCpp added the integration tests Run integration tests label Jul 30, 2022
@tomkarw tomkarw force-pushed the tomkarw/feat-implementation-of-collector-http-client-with-pure-hyper branch from d69f496 to 506cba5 Compare August 1, 2022 19:48
@tomkarw
Copy link
Contributor Author

tomkarw commented Aug 1, 2022

Hey @TommyCpp, I have no idea why the cargo doc keeps failing. I fixed a couple of the errors (even in unrelated parts of the code base), but this latest one in opentelemetry-proto is too much for me. I can't even reproduce it locally (the local docs look fine, and it's a crate that is not pushed publicly).

Could you lend me a hand, or maybe I can just [allow(clippy::...)] it?

@TommyCpp
Copy link
Contributor

TommyCpp commented Aug 2, 2022

Hey @TommyCpp, I have no idea why the cargo doc keeps failing. I fixed a couple of the errors (even in unrelated parts of the code base), but this latest one in opentelemetry-proto is too much for me. I can't even reproduce it locally (the local docs look fine, and it's a crate that is not pushed publicly).

Could you lend me a hand, or maybe I can just [allow(clippy::...)] it?

Thanks! coverage uses nightly build so it may have additional lint issue. I won't worry it too much. I will take a look and open a PR to fix it if needed.

@tomkarw tomkarw force-pushed the tomkarw/feat-implementation-of-collector-http-client-with-pure-hyper branch from da326cf to fac0580 Compare August 4, 2022 08:55
@tomkarw tomkarw force-pushed the tomkarw/feat-implementation-of-collector-http-client-with-pure-hyper branch 2 times, most recently from 0300bb3 to 6556032 Compare August 4, 2022 22:17
@tomkarw
Copy link
Contributor Author

tomkarw commented Aug 5, 2022

Hey @TommyCpp,

I've added hyper-with-tls support and refactored feature-conditional imports.

I deem this PR ready for review now.

@tomkarw tomkarw requested a review from TommyCpp August 5, 2022 10:51
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jtescher jtescher merged commit 399404d into open-telemetry:main Aug 8, 2022
@tomkarw tomkarw deleted the tomkarw/feat-implementation-of-collector-http-client-with-pure-hyper branch August 18, 2022 19:53
@lalitb lalitb mentioned this pull request May 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Implementation of CollectorHttpClient with pure hyper
3 participants