Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage tracer provider to set service name for Zipkin exporter #2624

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Feb 6, 2025

Fixes #
Design discussion issue (if applicable) #

Changes

  • continuation of feat: Replace Zipkin pipeline with exporter builders #2565 (comment)
    Removed the possibility to set service_name via the Zipkin exporter in favour of leveraging tracer provider
  • also removed an unused async_trait in NoopSpanExporter
  • slightly simplified with_simple_exporter()
  • some of the doc tests were not completely updated after changing the TracerProvider name

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner February 6, 2025 21:02
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of leftover cleanups too!

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (420416f) to head (00d3223).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pentelemetry-zipkin/src/exporter/model/endpoint.rs 60.0% 2 Missing ⚠️
opentelemetry-zipkin/src/exporter/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2624   +/-   ##
=====================================
  Coverage   79.0%   79.1%           
=====================================
  Files        119     119           
  Lines      22579   22554   -25     
=====================================
- Hits       17851   17847    -4     
+ Misses      4728    4707   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 61e539f into open-telemetry:main Feb 7, 2025
20 of 21 checks passed
@gruebel gruebel deleted the remove-service-name branch February 11, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants