Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move precomputed sum code to a new file #2036

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 19, 2024

Changes

  • Move precomputed sum code to a new file
  • This would also help keep the tests for sum and precomputed sum more manageable

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team August 19, 2024 18:09
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 98.01325% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (20625f9) to head (05cd920).
Report is 1 commits behind head on main.

Files Patch % Lines
...emetry-sdk/src/metrics/internal/precomputed_sum.rs 98.0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2036   +/-   ##
=====================================
  Coverage   76.8%   76.8%           
=====================================
  Files        122     123    +1     
  Lines      20984   20984           
=====================================
  Hits       16134   16134           
  Misses      4850    4850           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 3a4b17a into open-telemetry:main Aug 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants