Update active-job gem for rc2 Trace::Status syntax #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
approved these changes
Jun 29, 2021
ahayworth
approved these changes
Jun 29, 2021
d5a9d34 to
fef386e
Compare
fef386e to
69fa92c
Compare
fbogsany
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#805 removed the ability to call
OpenTelemetry::Trace::Status.newin favor of class level helper methods likeOpenTelemetry::Trace::Status.errorThis PR updates the usage of
OpenTelemetry::Trace::Statuswithin active_job instrumentation to conform with the new API as well as writes tests for the exception handling codepaths