-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling of install messages #831
Conversation
Is there a general log-level argument we could use instead? (Unless this is required by the spec, of course). |
Hmm, we do have
The context for this change is around users getting tired of the install message log spam, previously they would use I was already a little apprehensive to add a one off config for this. |
0af9935
to
306e169
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, thanks!
This is mainly to help us suppress the verbose output on enabling different instrumentations on startup in test environments, but also could be generally useful. More on the PR to enable it: open-telemetry/opentelemetry-ruby#831
This is mainly to help us suppress the verbose output on enabling different instrumentations on startup in test environments, but also could be generally useful. More on the PR to enable it: open-telemetry/opentelemetry-ruby#831
This is mainly to help us suppress the verbose output on enabling different instrumentations on startup in test environments, but also could be generally useful. More on the PR to enable it: open-telemetry/opentelemetry-ruby#831
This is mainly to help us suppress the verbose output on enabling different instrumentations on startup in test environments, but also could be generally useful. More on the PR to enable it: open-telemetry/opentelemetry-ruby#831
This is mainly to help us suppress the verbose output on enabling different instrumentations on startup in test environments, but also could be generally useful. More on the PR to enable it: open-telemetry/opentelemetry-ruby#831 Also updates encrypted config.yml for test runs on CI with new test configuration keys to lower Otel log level in test
Allows controlling the severity of the opentelemetry log messages emitted independently of the logger supplied.
This still allows for a user to override the
OpenTelemetry.logger
entirely via the accessorOpenTelemetry.logger =
, if you wish to supply a logger and still respect theOTEL_LOG_LEVEL
supplied environment variable this is done through the configuration.