-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Tracer.non_recording_span to API #799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a technical level, I think this change is 👍
On a spec level, it's a tad confusing to me so I feel like someone a little more knowledgeable about the spec should also sign-off. 😄
In light of #793 (comment) (TL;DR this method doesn't have to be an instance method on
My 2c: static method on |
Seems like the most convenient/consistent choice. |
instrumentation/rack/test/opentelemetry/instrumentation/rack_test.rb
Outdated
Show resolved
Hide resolved
instrumentation/rack/test/opentelemetry/instrumentation/rack_test.rb
Outdated
Show resolved
Hide resolved
…est.rb Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
…est.rb Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
Fixes #793
There's a lot going on here. The TL;DR is that
non_recording_span
an instance method onTracer
(becauseSpan
s can only be created by aTracer
), and we had a bunch of places that abusedSpan.new
(which we marked@api private
) and didn't have aTracer
instance handy.