Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording vs sampled #121

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Recording vs sampled #121

merged 5 commits into from
Oct 16, 2019

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Oct 16, 2019 •
edited
Loading

Includes #120

open-telemetry/opentelemetry-specification#291 states:

Span Processors will receive all spans with this flag (IsRecording) set. However, Span Exporter will not receive them unless the Sampled flag was set.

open-telemetry/opentelemetry-specification#296 replaced RECORD_AND_PROPAGATE with RECORD_AND_SAMPLED.

mwear
mwear approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment.

@fbogsany fbogsany merged commit 3b52ae0 into open-telemetry:master Oct 16, 2019
@fbogsany fbogsany deleted the recording-vs-sampled branch October 16, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@bai bai Awaiting requested review from bai

@luvtechno luvtechno Awaiting requested review from luvtechno

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbogsany @mwear