Merge branch 'issues-1722' of github.com:xuan-cao-swi/opentelemetry-r…

…uby into issues-1722
open-telemetry · Jan 10, 2025 · 73102bd · 73102bd
2 parents f3b8aa7 + 6544610
commit 73102bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram.rb b/metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram.rb
@@ -14,8 +14,7 @@ module OpenTelemetry
   module SDK
     module Metrics
       module Aggregation
-        # Contains the implementation of the ExponentialBucketHistogram aggregation
-        # https://opentelemetry.io/docs/specs/otel/metrics/data-model/#exponentialhistogram
+        # Contains the implementation of the {https://opentelemetry.io/docs/specs/otel/metrics/data-model/#exponentialhistogram ExponentialBucketHistogram} aggregation
         class ExponentialBucketHistogram # rubocop:disable Metrics/ClassLength
           attr_reader :aggregation_temporality
 
@@ -24,7 +23,7 @@ class ExponentialBucketHistogram # rubocop:disable Metrics/ClassLength
           MIN_SCALE = -10
           MAX_SIZE  = 160
 
-          # The default boundaries is calculated based on default max_size and max_scale value
+          # The default boundaries are calculated based on default max_size and max_scale values
           def initialize(
             aggregation_temporality: ENV.fetch('OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE', :delta),
             max_size: MAX_SIZE,

diff --git a/metrics_sdk/test/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram_test.rb b/metrics_sdk/test/opentelemetry/sdk/metrics/aggregation/exponential_bucket_histogram_test.rb
@@ -61,7 +61,7 @@
       _(exphdps[1].zero_threshold).must_equal(0)
     end
 
-    it 'rescale_with_alternating_growth_0' do
+    it 'rescales with alternating growth 0' do
       # Tests insertion of [2, 4, 1]. The index of 2 (i.e., 0) becomes
       # `indexBase`, the 4 goes to its right and the 1 goes in the last
       # position of the backing array. With 3 binary orders of magnitude