-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use Rack::Events for instrumentation #342
Merged
arielvalentin
merged 33 commits into
open-telemetry:main
from
arielvalentin:use-events-instead-of-middleware
Apr 5, 2023
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8698eb3
feat: Use Rack::Events for instrumentation
arielvalentin 24ea563
squash: additional feature parity
arielvalentin 06e4fe3
squash: add allowed response headers
arielvalentin 725b722
squash: url quantization
arielvalentin 8a2dd29
squash: Now with new Lemon Scented response headers
arielvalentin 752a739
squash: we are now at parity
arielvalentin aba820e
squash: use instrumetation config
arielvalentin 999594e
squash: Use declarative config options
arielvalentin 5261676
squash: fix bad refactoring
arielvalentin e66a188
convert proxy span to an event
arielvalentin 700f58f
refactor: move configurations to instrumentation install
arielvalentin 7154ec7
squash: add test converage
arielvalentin 69e60eb
squash: make response headers a little more resilient
arielvalentin 006cea0
squash: Ensures event middleware will not cause the application to cr…
arielvalentin 12c0e0f
squash: fix linter error
arielvalentin ee1c296
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin c37d534
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin ef52a8c
feat: Add middleware args helper for ActionPack and Sinatra
arielvalentin c53efcf
fix: test case
arielvalentin 3aee1c3
fix: Rack Events is autoloaded so if the parent module is present so …
arielvalentin fb5e826
fix: More precise error handling
arielvalentin 49f0bfe
fix: Ensure config is cleared/setup during installation
arielvalentin b7cad3f
fix: Sinatra 1.4 compatability
arielvalentin ce02dce
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin 0e50bba
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin 26c5a30
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin f134ec2
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin 16a4896
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin 205cd66
fix: bad merge
arielvalentin e9e837e
fix: invalid responses in test case
arielvalentin 0a961a1
squash: Added a few more test cases
arielvalentin 19d7c79
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin e88b745
Merge branch 'main' into use-events-instead-of-middleware
arielvalentin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: Add middleware args helper for ActionPack and Sinatra
- Loading branch information
commit ef52a8cba1ffb63bb8fab2d69896954da39fdac7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the long term plan (you may have answered this elsewhere)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration setting and helper will exist until...