Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented out test case #731

Merged
merged 3 commits into from
May 26, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -58,72 +58,3 @@ def test_export(self):
for export_status in self.span_processor.export_status:
self.assertEqual(export_status.name, "SUCCESS")
self.assertEqual(export_status.value, 0)


# FIXME This test fails because of an issue in the OpenCensus collector
# reported here:
# https://github.com/census-instrumentation/opencensus-service/issues/641
# Uncomment this test when this issue gets fixed.

# from time import sleep
# from opentelemetry.ext.opencensusexporter.metrics_exporter import (
# OpenCensusMetricsExporter,
# )
# from opentelemetry.sdk.metrics import Counter, MeterProvider
# from opentelemetry.sdk.metrics.export.controller import PushController

# from opentelemetry import metrics
#
#
# class ExportStatusMetricController(PushController):
# def __init__(self, *args, **kwargs):
# super().__init__(*args, **kwargs)
# self.export_status = []
#
# def run(self):
# while not self.finished.wait(self.interval):
# self.tick()
#
# def tick(self):
# # Collect all of the meter's metrics to be exported
# self.meter.collect()
# token = attach(set_value("suppress_instrumentation", True))
# # Export the given metrics in the batcher
# self.export_status.append(
# self.exporter.export(self.meter.batcher.checkpoint_set())
# )
# detach(token)
# # Perform post-exporting logic based on batcher configuration
# self.meter.batcher.finished_collection()
#
#
# class TestOpenCensusMetricsExporter(TestBase):
# def setUp(self):
# super().setUp()
#
# metrics.set_meter_provider(MeterProvider())
# self.meter = metrics.get_meter(__name__)
# self.controller = ExportStatusMetricController(
# self.meter,
# OpenCensusMetricsExporter(
# service_name="basic-service", endpoint="localhost:55678"
# ),
# 1,
# )
#
# def test_export(self):
#
# self.meter.create_metric(
# name="requests",
# description="number of requests",
# unit="1",
# value_type=int,
# metric_type=Counter,
# label_keys=("environment",),
# ).add(25, {"environment": "staging"})
#
# sleep(2)
#
# self.assertEqual(len(self.controller.export_status), 1)
# self.assertEqual(self.controller.export_status[0].name, "SUCCESS")
# self.assertEqual(self.controller.export_status[0].value, 0)