Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix propagation of http headers #709

Merged
merged 2 commits into from
May 27, 2020
Merged

fix propagation of http headers #709

merged 2 commits into from
May 27, 2020

Conversation

ecourreges-orange
Copy link
Contributor

fixes #682

TODO: add unit test that proves it

@ecourreges-orange ecourreges-orange requested a review from a team May 19, 2020 15:39
toumorokoshi
toumorokoshi reviewed May 20, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! if you can add a unit test happy to approve.

@toumorokoshi toumorokoshi mentioned this pull request May 20, 2020
Closed
@ecourreges-orange ecourreges-orange changed the title WIP: fix propagation of http headers fix propagation of http headers May 22, 2020
@ecourreges-orange
Copy link
Contributor Author

Note that I decided to add a basic test of the presence of the traceparent header in all requests emitted, rather than a new single test.

@ecourreges-orange
fix propagation of traceparent in aiohttp_client
a00d200 
add check presence of traceparent header in any aiohttp_client request
toumorokoshi
toumorokoshi approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@toumorokoshi toumorokoshi merged commit bc3ee80 into open-telemetry:master May 27, 2020
@toumorokoshi
Copy link
Member

thanks!

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22
fix: to tracer registry (open-telemetry#709)
8b62485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add instrumentation for aiohttp server
3 participants
@ecourreges-orange @toumorokoshi @ocelotl