Change set_attributes to take a Mapping #4374
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The attributes argument is currently specifies as a
Dict[str, types.AttributeValue]
, which is invariant in its value type. As a result, you cannot pass a dictionary with a narrower value type, e.g. adict[str, str]
. But that should be allowed, since set_attributes simply adds all key-value pairs in its argument, and all such pairs are valid. UsingMapping
takes care of this issue, since it's covariant in its value type.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Check this with
pyright
. Without this change, you get an error like:With this change, it passes.
Does This PR Require a Contrib Repo Change?
Checklist: