-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add attributes to get_meter wrapper #4364
Conversation
Hi! First time contributor here. I didn't knew if I needed to change the changelog or not. LMK if needed. Also, I couldn't find a specific test just for this specific interface, or any API in fact, so I didn't wanted to add a new test. But LMK if it's needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Maxi91f welcome! please add a changelog entry and also add a test in opentelemetry-api/tests/metrics/test_meter_provider.py
since it doesn't look this helper is tested
Thanks for the response @xrmx ! I'm doing it. |
Description
On #4015 the
attributes
parameter was added for meter providers, and all interfaces were updated, but the global wrapper was not updated with the new API.Since the function doc says that "This function is a convenience wrapper for
opentelemetry.metrics.MeterProvider.get_meter
." I expect this to have the same parameters.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
First I started a aws-otel-collector docker container for testing
Then I run this minimal script.
Without this PR this fails with
Now is working as expected.
Does This PR Require a Contrib Repo Change?
Checklist: