Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing def in example #4147

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Add missing def in example #4147

merged 2 commits into from
Aug 26, 2024

Conversation

avrong
Copy link
Contributor

@avrong avrong commented Aug 26, 2024

Description

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@avrong avrong requested a review from a team August 26, 2024 13:40
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 26, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: avrong / name: Aleksei Trifonov (5058708)
  • ✅ login: lzchen / name: Leighton Chen (e1ea8b4)

pmcollins
pmcollins approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 26, 2024
@lzchen lzchen merged commit 98d3b3e into open-telemetry:main Aug 26, 2024
376 checks passed
@avrong avrong deleted the patch-1 branch August 26, 2024 18:30
hyoinandout pushed a commit to hyoinandout/opentelemetry-python that referenced this pull request Aug 29, 2024
@avrong @hyoinandout
Add missing def in example (open-telemetry#4147)
8b80e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@pmcollins pmcollins pmcollins approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avrong @xrmx @pmcollins @lzchen