Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-test-utils: add async base test class for asgi #4106

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Aug 5, 2024

Description

This is required for trying to fix the issue below that is making the asgi tests work with latest release of asgiref.

Refs #2776

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx
Copy link
Contributor Author

xrmx commented Aug 22, 2024

Another small batch of green tests is won using a small timeout instead of 0 in AsyncAsgiTestBase.get_output for self.communicator.receive_output(0.1). That is making the tests slower though.

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 23, 2024
emdneto and others added 2 commits August 24, 2024 07:41
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@xrmx xrmx marked this pull request as ready for review August 24, 2024 13:06
@xrmx xrmx requested a review from a team August 24, 2024 13:06
@lzchen lzchen merged commit cb976b5 into open-telemetry:main Aug 26, 2024
376 checks passed
hyoinandout pushed a commit to hyoinandout/opentelemetry-python that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants