-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename version.py
files to version/__init__.py
#4099
Conversation
Wouldn't be simpler doing the other way around? It's not a module that I expect will grow in scope. What do you think? |
We want the version being specified in a |
Why we want that? |
version/__init__.py
files to version.py
After some discussion, we agreed that it would be better just to rename the |
version/__init__.py
files to version.py
version.py
files to version/__init__.py
Converting to draft to prevent accidental merging |
3c6d747
to
eb25474
Compare
After even more discussion we agreed to convert all version files to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you add some explanation to the PR description or issue of how we decided to go this route?
Fixes #4097
After a long consideration, we figured out that in order to be compliant with this we need to convert all single
version.py
files intoversion/__init__.py
files.Should we have also
py.typed
files in theversion
directory is something to be addressed later.