Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodicExportingMetricsReader with value = infinity to support explicit metric collection #3059

Merged
merged 29 commits into from
Feb 3, 2023
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f99a4fb
ExportingMetricsReporter and unit tests added,
howardyoo Nov 29, 2022
3dd484c
included ExportingMetricReader to the list of importable classes
howardyoo Nov 29, 2022
aa5b196
fixed incorrect parameter for the method.
howardyoo Nov 29, 2022
e5f6101
fixed minor bug in unit test code
howardyoo Nov 29, 2022
95e0cc6
fixed a lint issue.
howardyoo Nov 29, 2022
8d6d6df
fixing lint issues on the order of library imports
howardyoo Nov 29, 2022
523b428
another lint fix on the test code on the order of the library imports
howardyoo Nov 29, 2022
b9a2ee2
Merge branch 'main' into main
srikanthccv Dec 10, 2022
3fdca7d
Merge branch 'main' into main
srikanthccv Jan 2, 2023
809c049
1. removed ExportMetricReader related tests and codes
howardyoo Jan 4, 2023
4df9ddc
Merge branch 'main' into main
srikanthccv Jan 8, 2023
d7b52d1
Added example for zero interval periodic exporting metrics reader,
howardyoo Jan 9, 2023
2e4fad3
reformatting...
howardyoo Jan 10, 2023
d0a0664
Merge branch 'main' into main
lzchen Jan 12, 2023
e8bb84a
removed the examples for non-interval reader as a result of SIG discu…
howardyoo Jan 13, 2023
83266b0
Merge branch 'main' into main
lzchen Jan 13, 2023
9b4979a
minor changes in the code comment and changelog
howardyoo Jan 17, 2023
1dc1852
Merge branch 'open-telemetry:main' into main
howardyoo Jan 28, 2023
a891ae0
1) added support for math.inf which will disable interval thread
howardyoo Jan 28, 2023
97fe654
Update CHANGELOG.md
howardyoo Jan 30, 2023
d59be9c
Update opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/expo…
howardyoo Jan 30, 2023
bd4c62e
Merge branch 'main' into main
lzchen Jan 30, 2023
5c06eac
Update opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/expo…
howardyoo Feb 2, 2023
2b5029a
Merge branch 'main' into main
srikanthccv Feb 2, 2023
c042bed
Merge branch 'main' into main
srikanthccv Feb 2, 2023
a5cbed0
Update opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/expo…
howardyoo Feb 2, 2023
24da061
Merge branch 'open-telemetry:main' into main
howardyoo Feb 3, 2023
16330da
fixed incorrect reference to self.
howardyoo Feb 3, 2023
436ad0f
make sure to have the _daemon_thread set to None
howardyoo Feb 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/expo…
…rt/__init__.py


LGTM

Co-authored-by: Aaron Abbott <aaronabbott@google.com>
  • Loading branch information
howardyoo and aabmass authored Feb 2, 2023
commit 5c06eac2041881bf20922a492b1f6067870cb42e
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,6 @@ def __init__(
self._shutdown = False
self._shutdown_event = Event()
self._shutdown_once = Once()
print(f"interval is set to {self._export_interval_millis}")
if (
self._export_interval_millis > 0
and self._export_interval_millis < math.inf
Expand Down