TestBase and SpanTestBase are redundant #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lzchen
reviewed
Jun 13, 2022
lzchen
reviewed
Jun 13, 2022
lzchen
reviewed
Jun 13, 2022
lzchen
approved these changes
Jun 13, 2022
aabmass
approved these changes
Jun 13, 2022
tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
Outdated
Show resolved
Hide resolved
tests/opentelemetry-test-utils/src/opentelemetry/test/spantestutil.py
Outdated
Show resolved
Hide resolved
ocelotl
approved these changes
Jun 13, 2022
…hon into issue-1993
…hon into issue-1993
|
Ready to merge, @srikanthccv please mark conversations as resolved if possible ✌️ |
|
I believe there is cache issue because contrib tests fail with the latest move to |
I see all tests passing 🤷 |
|
they are failing here https://github.com/open-telemetry/opentelemetry-python-contrib/runs/6872695613?check_suite_focus=true. @lzchen do you mind if I create another issue to address moving the tracing code to |
|
@srikanthccv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the redundant setup code in
SpanTestBaseand moves the metrics setup to instance methods.Fixes #1993
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
toxDoes This PR Require a Contrib Repo Change?
Checklist: