Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_remote_parent span flags to OTLP exported Spans and SpanLinks #3876

Closed
xrmx opened this issue Apr 24, 2024 · 0 comments · Fixed by #3881
Closed

Add is_remote_parent span flags to OTLP exported Spans and SpanLinks #3876

xrmx opened this issue Apr 24, 2024 · 0 comments · Fixed by #3881

Comments

@xrmx
Copy link
Contributor

xrmx commented Apr 24, 2024

Is your feature request related to a problem?

After updating protobuf schema to 1.2.0 in 1164ab6 we can set the is_remote_parent flag when exporting spans and span links with OTLP.

Describe the solution you'd like

Update OTLP exporter to fill the relevant bits in SpanFlags.

Describe alternatives you've considered

none

Additional context

Proto schema PR: open-telemetry/opentelemetry-proto#484
Go implementation: https://github.com/open-telemetry/opentelemetry-go/pull/5194/files

xrmx added a commit to xrmx/opentelemetry-python that referenced this issue Apr 26, 2024
…links

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes open-telemetry#3876
xrmx added a commit to xrmx/opentelemetry-python that referenced this issue Apr 26, 2024
…links

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes open-telemetry#3876
xrmx added a commit to xrmx/opentelemetry-python that referenced this issue Apr 26, 2024
…links

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes open-telemetry#3876
xrmx added a commit to xrmx/opentelemetry-python that referenced this issue Apr 29, 2024
…links

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes open-telemetry#3876
xrmx added a commit to xrmx/opentelemetry-python that referenced this issue May 7, 2024
…links

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes open-telemetry#3876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant