Skip to content

Commit

Permalink
Fix the syntax for running sub command in workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
NathanielRN committed Dec 23, 2020
1 parent b29627a commit 6c6781c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,16 @@ jobs:
- name: run tox
run: tox -f ${{ matrix.python-version }}-${{ matrix.package }} -- --benchmark-json=${{ env.RUN_MATRIX_COMBINATION }}-benchmark.json
- name: Find and merge benchmarks
id: find_and_merge_benchmarks
run: >-
jq -s '.[0].benchmarks = ([.[].benchmarks] | add)
| if .[0].benchmarks == null then null else .[0] end'
`find . -name '*${{ matrix.package }}*-benchmark.json'` > output.json
$(find . -name '*${{ matrix.package }}*-benchmark.json') > output.json
&& echo "::set-output name=json_plaintext::$(cat output.json)"
- name: What is in the output value
run: echo ${{ steps.find_and_merge_benchmarks.outputs.benchmark_results_json }}
- name: Report on benchmark results
if: `cat output.json` == null
if: steps.find_and_merge_benchmarks.outputs.json_plaintext != null
uses: rhysd/github-action-benchmark@v1
with:
name: OpenTelemetry Python Benchmarks - Python ${{ env[matrix.python-version ]}} - ${{ matrix.package }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
def get_tracer_with_processor(span_processor_class):
span_processor = span_processor_class(OTLPSpanExporter())
tracer = TracerProvider(
active_span_processor=span_processor,
sampler=sampling.DEFAULT_ON,
active_span_processor=span_processor, sampler=sampling.DEFAULT_ON,
).get_tracer("pipeline_benchmark_tracer")
return tracer

Expand Down

0 comments on commit 6c6781c

Please sign in to comment.